HAL_GPT_LLD.C TIMv1 - dublicate code block Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
alexblack
Posts: 239
Joined: Mon Sep 24, 2012 3:52 pm
Location: Donetsk
Been thanked: 27 times
Contact:

HAL_GPT_LLD.C TIMv1 - dublicate code block  Topic is solved

Postby alexblack » Thu Jan 16, 2020 6:36 pm

Hi.
ChibiOS stable19.1.x branch.
File ../os/hal/ports/STM32/LLD/TIMv1/hal_gpt_lld.c :

Code: Select all

...
802 #if STM32_GPT_USE_TIM15
803     if (&GPTD15 == gptp) {
804       rccEnableTIM15(true);
805       rccResetTIM15();
806 #if defined(STM32_TIM15CLK)
807       gptp->clock = STM32_TIM15CLK;
808 #else
809       gptp->clock = STM32_TIMCLK2;
810 #endif
811     }
812 #endif
813
814 #if STM32_GPT_USE_TIM15
815     if (&GPTD15 == gptp) {
816       rccEnableTIM15(true);
817       rccResetTIM15();
818 #if defined(STM32_TIM15CLK)
819       gptp->clock = STM32_TIM15CLK;
820 #else
821       gptp->clock = STM32_TIMCLK2;
822 #endif
823     }
824 #endif
...

Lines 802-813 and 815-825 are identical.

User avatar
Giovanni
Site Admin
Posts: 12943
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 729 times
Been thanked: 609 times
Contact:

Re: HAL_GPT_LLD.C TIMv1 - dublicate code block

Postby Giovanni » Thu Jan 16, 2020 7:03 pm

Hi,

Moving to bug reports.

Giovanni

User avatar
Giovanni
Site Admin
Posts: 12943
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 729 times
Been thanked: 609 times
Contact:

Re: HAL_GPT_LLD.C TIMv1 - dublicate code block

Postby Giovanni » Fri Jan 17, 2020 9:58 am

Fixed (in trunk) as bug #1067.

Will backport later.

Giovanni

User avatar
Giovanni
Site Admin
Posts: 12943
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 729 times
Been thanked: 609 times
Contact:

Re: HAL_GPT_LLD.C TIMv1 - dublicate code block

Postby Giovanni » Sat Jan 18, 2020 11:16 am

Backported to 19.1 and 18.2.

Giovanni

m0rsch1
Posts: 2
Joined: Tue Feb 18, 2020 1:29 pm

Re: HAL_GPT_LLD.C TIMv1 - dublicate code block

Postby m0rsch1 » Tue Feb 18, 2020 1:38 pm

Hi there,

for me fix #1067 does not fix this issue.
Can you please check again?

BR,

M0rsch1

User avatar
Giovanni
Site Admin
Posts: 12943
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 729 times
Been thanked: 609 times
Contact:

Re: HAL_GPT_LLD.C TIMv1 - dublicate code block

Postby Giovanni » Tue Feb 18, 2020 3:13 pm

Hi,

Fixed as bug #1074.

Bug #1067 was something else.

Giovanni


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 4 guests