warning compiling chibios 20.3 with gcc 10.2 Topic is solved

[alex31]

Hello,

I am doing experiment with c++20, and need g++10, so i went over this bug :

Code: Select all

In function 'dyn_create_object_heap',
    inlined from 'dyn_create_object_heap' at ../../../ChibiOS_20.3_stable/os/oslib/src/chfactory.c:124:23:
../../../ChibiOS_20.3_stable/os/oslib/src/chfactory.c:146:3: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation]
  146 |   strncpy(dep->name, name, CH_CFG_FACTORY_MAX_NAMES_LENGTH);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Compiling chcore.c
Compiling chcore_v7m.c
In function 'dyn_create_object_pool',
    inlined from 'dyn_create_object_pool' at ../../../ChibiOS_20.3_stable/os/oslib/src/chfactory.c:172:23:
../../../ChibiOS_20.3_stable/os/oslib/src/chfactory.c:194:3: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation]
  194 |   strncpy(dep->name, name, CH_CFG_FACTORY_MAX_NAMES_LENGTH);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


If it's OK that dep->name is not null terminated when length is equal to CH_CFG_FACTORY_MAX_NAMES_LENGTH, it's a false positive.

Probably a new check that gcc10 does.


Alexandre

[Giovanni]

Hi,

It is meant to not be zero terminated if the length is equal to buffer size, not sure about how to handle the warning.

Giovanni

[alex31]

yes, probably that

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wstringop-truncation"
#pragma GCC diagnostic pop

is a bit to much gcc specific ...

Alexandre

[mikeprotts]

It is meant to not be zero terminated if the length is equal to buffer size, not sure about how to handle the warning.

So the destination is a character array rather than a string.

The logic seems to be:

Code: Select all

if (strlen(name) < CH_CFG_FACTORY_MAX_NAMES_LENGTH)
{
  strncpy(dep->name, name, CH_CFG_FACTORY_MAX_NAMES_LENGTH);
}
else
{
  memcpy(dep->name, name, CH_CFG_FACTORY_MAX_NAMES_LENGTH);
}


This might also be coded as:

Code: Select all

chDbgAssert(strlen(name) <= CH_CFG_FACTORY_MAX_NAMES_LENGTH, "factory name too long");
memcpy(dep->name, name, strlen(name));
if (strlen(name) < CH_CFG_FACTORY_MAX_NAMES_LENGTH)
{
  dep->name[strlen(name)]= 0;
}


However that leaves the section of dep->name from strlen(name) to CH_CFG_FACTORY_MAX_NAMES_LENGTH as undefined, so may be better to use:

Code: Select all

chDbgAssert(strlen(name) <= CH_CFG_FACTORY_MAX_NAMES_LENGTH, "factory name too long");
memset(dep->name, 0, CH_CFG_FACTORY_MAX_NAMES_LENGTH);
memcpy(dep->name, name, strlen(name));


which is probably more efficient than

Code: Select all

chDbgAssert(strlen(name) <= CH_CFG_FACTORY_MAX_NAMES_LENGTH, "factory name too long");
memcpy(dep->name, name, strlen(name));
memset(dep->name, strlen(name), CH_CFG_FACTORY_MAX_NAMES_LENGTH - strlen(name));


Mike

[Giovanni]

Probably the easiest way is to replace strncpy() with a local function in that module.

Giovanni

[Giovanni]

Hi,

Fixed as bug #1139.

Giovanni