Theodore ATEBA wrote:The else if of course for the low level mode(EXT_CH_MODE_LOW_LEVEL). May be I should use it explicitly, just want to know for next time.
Suppose there are new modes added in the future. The user than passes some unsupported mode, our code would run the low_level interrupt mode although that's not what should happen. So the correct behavior would be to be explicit in the test. I think the else should not exist there.
Would be happy to get a new patch for this!