[PATCH] make the shell work on NIL again Topic is solved

Use this forum for requesting small changes in ChibiOS. Large changes should be discussed in the development forum. This forum is NOT for support.
electronic_eel
Posts: 77
Joined: Sat Mar 19, 2016 8:07 pm
Been thanked: 17 times

[PATCH] make the shell work on NIL again  Topic is solved

Postby electronic_eel » Mon Aug 27, 2018 1:57 pm

Hi,

the shell doesn't compile in current trunk when used with NIL. The reason is that the chThdShouldTerminateX() and chEvtObjectInit() functions are missing.

I attached a patch to fix this. I made the whole shell thread exit logic optional with the SHELL_EXIT_ENABLED define. This is enabled by default on RT, but disabled on NIL.

I also added another patch with small output improvements.

Would it make sense to have a testcase with shell and NIL? For example in testhal or demos. Then it would be more easy to spot problems like this in the future.

Thanks for considering.
Attachments
patch-shell-on-nil.zip
(2.55 KiB) Downloaded 169 times

User avatar
Giovanni
Site Admin
Posts: 14457
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: [PATCH] make the shell work on NIL again

Postby Giovanni » Sun Jan 06, 2019 10:17 am

Hi,

Not merging, next NIL will be able to create/exit threads (it is already working look under /branches/nil_4_dev).

Giovanni

electronic_eel
Posts: 77
Joined: Sat Mar 19, 2016 8:07 pm
Been thanked: 17 times

Re: [PATCH] make the shell work on NIL again

Postby electronic_eel » Sun Jan 06, 2019 5:05 pm

Giovanni wrote:next NIL will be able to create/exit threads

That is an even better solution than mine, thanks ;)

Do you also plan to implement the full events source/listener mechanism for the next NIL release, as hinted here: [INFO] Nil growing (not in size)?

User avatar
Giovanni
Site Admin
Posts: 14457
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: [PATCH] make the shell work on NIL again

Postby Giovanni » Sun Jan 06, 2019 5:08 pm

Hi,

It is an open point, now it would be able to support it.

Giovanni


Return to “Small Change Requests”

Who is online

Users browsing this forum: No registered users and 33 guests