Hello,
I have recently begun using ChibiOS and have noticed something that I believe may be a design inconsistency. Guarded and unguarded memory pools both provide a chXyzObjectInit and chXyzObjectInitAligned function so that the user can specify their own memory alignment if necessary. However, chFifo provides only chFifoObjectInit, which requires a memory alignment despite a function name that (if consistent with memory pools) implies the internal use of PORT_NATURAL_ALIGN when this is not the case.
I suggest changing the existing function to chFifoObjectInitAligned, and writing another chFifoObjectInit that uses PORT_NATURAL_ALIGN to call chFifoObjectInitAligned.
Please let me know if I have misunderstood something (and thanks for your time).
Add chFifoObjectInitAligned Topic is solved
- Giovanni
- Site Admin
- Posts: 14444
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1074 times
- Been thanked: 921 times
- Contact:
Re: Add chFifoObjectInitAligned
Hi,
It is feasible and in queue. It is just about adding another static inline function.
it requires an API change so it will go in next major release.
Giovanni
It is feasible and in queue. It is just about adding another static inline function.
it requires an API change so it will go in next major release.
Giovanni
- Giovanni
- Site Admin
- Posts: 14444
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1074 times
- Been thanked: 921 times
- Contact:
Return to “Small Change Requests”
Who is online
Users browsing this forum: No registered users and 12 guests