It makes sense, I will add switches to disable single ISRs without impacting others.
Giovanni
Adding an argument to PAL event callbacks Topic is solved
- Giovanni
- Site Admin
- Posts: 14455
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1076 times
- Been thanked: 922 times
- Contact:
- FXCoder
- Posts: 384
- Joined: Sun Jun 12, 2016 4:10 am
- Location: Sydney, Australia
- Has thanked: 180 times
- Been thanked: 130 times
Re: Adding an argument to PAL event callbacks
Thanks Giovanni.
I see you were busy on the weekend and the defines are there.
I added definitions in mcuconf.h for PAL vector override.
For consistency can I suggest adopting the same structure as used for other settings so that the setting can be explicitly shown (TRUE/FALSE)?
More work I know...
In mcuconf.h
etc...
Then in stm32_isr.c
etc...
And in stm32_isr.h
etc...
I see you were busy on the weekend and the defines are there.
I added definitions in mcuconf.h for PAL vector override.
For consistency can I suggest adopting the same structure as used for other settings so that the setting can be explicitly shown (TRUE/FALSE)?
More work I know...
In mcuconf.h
Code: Select all
/*
* PAL driver system settings.
*/
#define STM32_DISABLE_EXTI1_HANDLER TRUE
etc...
Then in stm32_isr.c
Code: Select all
#if !STM32_DISABLE_EXTI1_HANDLER
/**
* @brief EXTI[1] interrupt handler.
*
* @isr
*/
etc...
And in stm32_isr.h
Code: Select all
/**
* @name Configuration options
* @{
*/
/**
* @brief EXTI0 interrupt override setting.
*/
#if !defined(STM32_DISABLE_EXTI0_HANDLER) || defined(__DOXYGEN__)
#define STM32_DISABLE_EXTI0_HANDLER FALSE
#endif
etc...
- Giovanni
- Site Admin
- Posts: 14455
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1076 times
- Been thanked: 922 times
- Contact:
Re: Adding an argument to PAL event callbacks
Hi,
I prefer to not bring so many arcane switches in mcuconf.h, it is already quite complex as is. I think simple definitions are fine for this use case and need no checks.
Giovanni
I prefer to not bring so many arcane switches in mcuconf.h, it is already quite complex as is. I think simple definitions are fine for this use case and need no checks.
Giovanni
- Giovanni
- Site Admin
- Posts: 14455
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1076 times
- Been thanked: 922 times
- Contact:
Re: Adding an argument to PAL event callbacks
Correct, in alternative twitches could be placed in makefiles -D...
Giovanni
Giovanni
Return to “Small Change Requests”
Who is online
Users browsing this forum: No registered users and 9 guests