Page 1 of 1

I2Cv3 update to use new dmaStreamFree(...) instead of dmaStreamRelease(...)

Posted: Mon Mar 11, 2019 2:40 am
by FXCoder

Code: Select all

Index: hal_i2c_lld.c
===================================================================
--- hal_i2c_lld.c   (revision 12685)
+++ hal_i2c_lld.c   (working copy)
@@ -981,8 +981,8 @@
 #endif
 #if defined(STM32_I2C_BDMA_REQUIRED)
     {
-      bdmaStreamRelease(i2cp->rx.bdma);
-      bdmaStreamRelease(i2cp->tx.bdma);
+      bdmaStreamFree(i2cp->rx.bdma);
+      bdmaStreamFree(i2cp->tx.bdma);
     }
 #endif
 #if defined(STM32_I2C_DMA_REQUIRED) && defined(STM32_I2C_BDMA_REQUIRED)
@@ -990,8 +990,8 @@
 #endif
 #if defined(STM32_I2C_DMA_REQUIRED)
     {
-      dmaStreamRelease(i2cp->rx.dma);
-      dmaStreamRelease(i2cp->tx.dma);
+      dmaStreamFree(i2cp->rx.dma);
+      dmaStreamFree(i2cp->tx.dma);
     }
 #endif
 


Documentation in DMAv1 .h file also needs to be changed to refer to dmaStreamFree(...) in lieu of dmaStreamRelease(...)

Re: I2Cv3 update to use new dmaStreamFree(...) instead of dmaStreamRelease(...)

Posted: Mon Mar 11, 2019 5:38 am
by Giovanni
I thought I changed them all...

Thanks for finding.

Giovanni

Re: I2Cv3 update to use new dmaStreamFree(...) instead of dmaStreamRelease(...)

Posted: Mon Mar 11, 2019 10:59 am
by FXCoder
Doing some more on the L4+ based version of Pecan project this week so we’ll keep you advised of any more findings.

Bob

Re: I2Cv3 update to use new dmaStreamFree(...) instead of dmaStreamRelease(...)  Topic is solved

Posted: Fri Mar 15, 2019 5:22 pm
by Giovanni
Hi,

Fixed as bug #1019.

Giovanni