I2Cv3 update to use new dmaStreamFree(...) instead of dmaStreamRelease(...) Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
User avatar
FXCoder
Posts: 184
Joined: Sun Jun 12, 2016 4:10 am
Location: Sydney, Australia
Has thanked: 66 times
Been thanked: 52 times

I2Cv3 update to use new dmaStreamFree(...) instead of dmaStreamRelease(...)

Postby FXCoder » Mon Mar 11, 2019 2:40 am

Code: Select all

Index: hal_i2c_lld.c
===================================================================
--- hal_i2c_lld.c   (revision 12685)
+++ hal_i2c_lld.c   (working copy)
@@ -981,8 +981,8 @@
 #endif
 #if defined(STM32_I2C_BDMA_REQUIRED)
     {
-      bdmaStreamRelease(i2cp->rx.bdma);
-      bdmaStreamRelease(i2cp->tx.bdma);
+      bdmaStreamFree(i2cp->rx.bdma);
+      bdmaStreamFree(i2cp->tx.bdma);
     }
 #endif
 #if defined(STM32_I2C_DMA_REQUIRED) && defined(STM32_I2C_BDMA_REQUIRED)
@@ -990,8 +990,8 @@
 #endif
 #if defined(STM32_I2C_DMA_REQUIRED)
     {
-      dmaStreamRelease(i2cp->rx.dma);
-      dmaStreamRelease(i2cp->tx.dma);
+      dmaStreamFree(i2cp->rx.dma);
+      dmaStreamFree(i2cp->tx.dma);
     }
 #endif
 


Documentation in DMAv1 .h file also needs to be changed to refer to dmaStreamFree(...) in lieu of dmaStreamRelease(...)

User avatar
Giovanni
Site Admin
Posts: 12021
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 543 times
Been thanked: 455 times
Contact:

Re: I2Cv3 update to use new dmaStreamFree(...) instead of dmaStreamRelease(...)

Postby Giovanni » Mon Mar 11, 2019 5:38 am

I thought I changed them all...

Thanks for finding.

Giovanni

User avatar
FXCoder
Posts: 184
Joined: Sun Jun 12, 2016 4:10 am
Location: Sydney, Australia
Has thanked: 66 times
Been thanked: 52 times

Re: I2Cv3 update to use new dmaStreamFree(...) instead of dmaStreamRelease(...)

Postby FXCoder » Mon Mar 11, 2019 10:59 am

Doing some more on the L4+ based version of Pecan project this week so we’ll keep you advised of any more findings.

Bob

User avatar
Giovanni
Site Admin
Posts: 12021
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 543 times
Been thanked: 455 times
Contact:

Re: I2Cv3 update to use new dmaStreamFree(...) instead of dmaStreamRelease(...)  Topic is solved

Postby Giovanni » Fri Mar 15, 2019 5:22 pm

Hi,

Fixed as bug #1019.

Giovanni


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 2 guests