#951 for STM32F1xx Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
User avatar
wurstnase
Posts: 121
Joined: Tue Oct 17, 2017 2:24 pm
Has thanked: 43 times
Been thanked: 30 times
Contact:

#951 for STM32F1xx  Topic is solved

Postby wurstnase » Thu Jun 07, 2018 10:38 am

Hi,

there is no oversampling for STM32F103. On the STM32F1xx line I found only the OVER8 bit for STM32F100xb/e.

Code: Select all

Compiling chtrace.c
../../chibios182/os/hal/ports/STM32/LLD/USARTv1/hal_serial_lld.c: In function 'usart_init':
../../chibios182/os/hal/ports/STM32/LLD/USARTv1/hal_serial_lld.c:118:21: error: 'USART_CR1_OVER8' undeclared (first use in this function); did you mean 'USART_CR1_TE'?
   if (config->cr1 & USART_CR1_OVER8)
                     ^~~~~~~~~~~~~~~
                     USART_CR1_TE
../../chibios182/os/hal/ports/STM32/LLD/USARTv1/hal_serial_lld.c:118:21: note: each undeclared identifier is reported only once for each function it appears in
make: *** [../../chibios182/os/common/startup/ARMCMx/compilers/GCC/rules.mk:234: build/obj/hal_serial_lld.o] Error 1
make: *** Waiting for unfinished jobs....
Compiling chschd.c
\o/ Nico

User avatar
Giovanni
Site Admin
Posts: 14455
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: #951 for STM32F1xx

Postby Giovanni » Sat Jun 09, 2018 6:28 pm

Hi,

Added a check about that, it should be fine now.

Giovanni

josesimoes
Posts: 91
Joined: Sat Feb 18, 2017 11:50 am
Has thanked: 43 times
Been thanked: 23 times

Re: #951 for STM32F1xx

Postby josesimoes » Mon Jun 11, 2018 10:39 am

Hi,

The fix introduced another bug: it's missing the "uartp->" at line 220.

It should be "if (uartp->config->cr1 & USART_CR1_OVER8)"

Right now that is breaking the build.

User avatar
Giovanni
Site Admin
Posts: 14455
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: #951 for STM32F1xx

Postby Giovanni » Fri Jun 15, 2018 10:38 am

Hi,

Fixed in repository.

Giovanni


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 19 guests