CANFilter struct documentation bug Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
lungj
Posts: 8
Joined: Wed Feb 03, 2016 7:57 am
Been thanked: 1 time

CANFilter struct documentation bug  Topic is solved

Postby lungj » Wed May 23, 2018 5:52 pm

This bug pertains to the documentation of the CANFilter struct. The .filter field states that the field is for the "Number of the filter to be programmed". This is true when .scale is 1 (32-bit filters) and .mode is 1 (mask mode); however, it is false when .scale and/or .mode are/is 0. One filter bank contains more than one filter (which are numbered by "filter number" by ST on, for example, figure 393 of RM0390 Revision 4) when 16-bit filters are used and/or when the CAN filter is using identifier mode.

Proposed change to use ST's terminology: "Number of the filter bank to be programmed."

(Also, both registers 1 and 2 may also contain mask AND identifier when .filter = 1 and .scale = 0; the documentation for .register1 states that it is the identifier and that .register2 is the mask/identifier depending on mode)

User avatar
Giovanni
Site Admin
Posts: 14444
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1074 times
Been thanked: 921 times
Contact:

Re: CANFilter struct documentation bug

Postby Giovanni » Fri Jun 01, 2018 9:04 am

Hi,

Fixed in repository, thanks.

Giovanni


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 22 guests