STM32F7xx hal_lld.h issue after "Fixed bug #913" Topic is solved

[ych]

During "Fixed bug #913" (git-svn-id: svn://svn.code.sf.net/p/chibios/svn/trunk@11345 35acf78f-673a-0410-8e92-d51de3d6d3f4) not all condition was properly updated, so the patch:

Code: Select all

diff --git a/os/hal/ports/STM32/STM32F7xx/hal_lld.h b/os/hal/ports/STM32/STM32F7xx/hal_lld.h
index 24498264e..47c91b62c 100644
--- a/os/hal/ports/STM32/STM32F7xx/hal_lld.h
+++ b/os/hal/ports/STM32/STM32F7xx/hal_lld.h
@@ -1997,7 +1997,7 @@
  */
 #if (STM32_SDMMC1SEL == STM32_SDMMC1SEL_PLL48CLK) || defined(__DOXYGEN__)
 #define STM32_SDMMC1CLK              STM32_PLL48CLK
-#elif STM32_SDMMC1SEL == STM32_SDMMCSEL_SYSCLK
+#elif STM32_SDMMC1SEL == STM32_SDMMC1SEL_SYSCLK
 #define STM32_SDMMC1CLK              STM32_SYSCLK
 #else
 #error "invalid source selected for SDMMC1 clock"
@@ -2006,9 +2006,9 @@
 /**
  * @brief   SDMMC2 frequency.
  */
-#if (STM32_SDMMC2SEL == STM32_SDMMC1SEL_PLL48CLK) || defined(__DOXYGEN__)
+#if (STM32_SDMMC2SEL == STM32_SDMMC2SEL_PLL48CLK) || defined(__DOXYGEN__)
 #define STM32_SDMMC2CLK              STM32_PLL48CLK
-#elif STM32_SDMMC2SEL == STM32_SDMMCSEL_SYSCLK
+#elif STM32_SDMMC2SEL == STM32_SDMMC2SEL_SYSCLK
 #define STM32_SDMMC2CLK              STM32_SYSCLK
 #else
 #error "invalid source selected for SDMMC2 clock"


[Giovanni]

Hi,

Fixed as bug #928.

Giovanni

[ych]

Aha, ok.
Is it better to create a bug in ChibiOS SourceForce project then on the forum?

[Giovanni]

The forum is OK especially if it requires discussion, I create the ticket on the tracker anyway.

Giovanni