ICU notification behavior differ between code and doc Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
User avatar
alex31
Posts: 221
Joined: Fri May 25, 2012 10:23 am
Location: toulouse, france
Has thanked: 8 times
Been thanked: 17 times
Contact:

ICU notification behavior differ between code and doc  Topic is solved

Postby alex31 » Mon Mar 19, 2018 1:38 pm

Hello,

In the ICU driver, the doc say :
icuEnableNotifications
Precondition
The ICU unit must have been activated using icuStart().


In the code, been activated using icuStart() is not sufficient, and a capture has to be started too.

Code: Select all

 
  osalDbgAssert((icup->state == ICU_WAITING) || (icup->state == ICU_ACTIVE),
                "invalid state");

Note that ICU_READY is not a valid state.


That implies enabling notification every time a capture is started.

I would have found more natural to enable notification just once after starting the ICU.

Alexandre

User avatar
Giovanni
Site Admin
Posts: 11156
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 392 times
Been thanked: 323 times
Contact:

Re: ICU notification behavior differ between code and doc

Postby Giovanni » Fri Mar 23, 2018 12:59 pm

Hi,

I fixed the documentation, there were technical reasons for notifications to be enabled after capture.

Giovanni


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 3 guests