Missing#includes in os/hal/include Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
faisal
Posts: 374
Joined: Wed Jul 19, 2017 12:44 am
Has thanked: 44 times
Been thanked: 60 times

Missing#includes in os/hal/include  Topic is solved

Postby faisal » Wed Feb 21, 2018 6:33 pm

hal_mmcsd.h depends on hal_ioblock.h, and it is not included.
hal_mmc_spi.h depends on hal_mmcsd.h, and it is not included.

Looking thru other files in hal/include - I noticed there may be other #includes missing as well. Is this intentional?

User avatar
Giovanni
Site Admin
Posts: 14455
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: Missing#includes in os/hal/include

Postby Giovanni » Fri Feb 23, 2018 10:01 am

Hi,

Aren't those files included by hal.h?

Giovanni

faisal
Posts: 374
Joined: Wed Jul 19, 2017 12:44 am
Has thanked: 44 times
Been thanked: 60 times

Re: Missing#includes in os/hal/include

Postby faisal » Sun Feb 25, 2018 6:46 pm

Giovanni wrote:Hi,

Aren't those files included by hal.h?

Giovanni


Yeah, I think they are. So the idea is that within the HAL you don't include all dependencies individually, just hal.h.


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 4 guests