Minor cleanups Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
steved
Posts: 823
Joined: Fri Nov 09, 2012 2:22 pm
Has thanked: 12 times
Been thanked: 135 times

Minor cleanups  Topic is solved

Postby steved » Fri Jan 19, 2018 2:38 pm

A few points:
1. CORTEX_VTOR_INIT appears to be redundant, but still features in a number of the chconf.h files (demos and test directories)

2. In ST's hal_qspi_lld.c, the comment for qspi_lld_unmap_flash() is incorrect (obviously copy & paste from its counterpart, and not updated fully)

3. In the test/demo for QSPI, memory-mapped mode is set; however no data is read/verified before exiting the mode. So does it actually work? (Not yet for me, with a different flash chip, but still trying).

User avatar
Giovanni
Site Admin
Posts: 14444
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1074 times
Been thanked: 921 times
Contact:

Re: Minor cleanups

Postby Giovanni » Fri Jan 19, 2018 2:44 pm

I tested the memory mapped mode by looking memory with a debugger, it is possible that it is related to the device, memory mapped mode uses a fast read mode. You need to enter/leave fast mode and that is device-dependent.

Giovanni

steved
Posts: 823
Joined: Fri Nov 09, 2012 2:22 pm
Has thanked: 12 times
Been thanked: 135 times

Re: Minor cleanups

Postby steved » Fri Jan 19, 2018 3:44 pm

Giovanni wrote:I tested the memory mapped mode by looking memory with a debugger, it is possible that it is related to the device, memory mapped mode uses a fast read mode. You need to enter/leave fast mode and that is device-dependent.
Giovanni

That's what I did initially as well (except that I made my code read it out), and it appeared to work with a 128-byte test buffer. I'm at the point where 'normal' read and write appear to work OK on a 16K file, but the mapping gets lost when I change to memory mapping for the same data. About to break out the logic analyser!

User avatar
Giovanni
Site Admin
Posts: 14444
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1074 times
Been thanked: 921 times
Contact:

Re: Minor cleanups

Postby Giovanni » Sat Jan 20, 2018 4:33 pm

Points 1 and 2 fixed, thanks.

Giovanni


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 19 guests