CAN structure size Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
steved
Posts: 825
Joined: Fri Nov 09, 2012 2:22 pm
Has thanked: 12 times
Been thanked: 135 times

CAN structure size  Topic is solved

Postby steved » Fri Nov 24, 2017 11:04 am

In hal_can_lld.h, struct CANFilter defines field 'filter' as uint32_t. If it's redefined as filter:16, the size of the structure reduces from 16 to 12 bytes; a worthwhile saving given that a number of structures may be required to define the filters.

Also in the same structure, the comment for field 'assignment' (affecting FFAR1 bit) is incorrect. Firstly, it's not 'filter mode'; it determines whether matching messages are directed to RxFIFO0 or RxFIFO1. Secondly, the comment says it must be set to zero in this version of the driver. However the receive handler looks as if this bit is indeed supported.

User avatar
Giovanni
Site Admin
Posts: 14455
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: CAN structure size

Postby Giovanni » Thu Jan 18, 2018 9:22 am

Change committed thanks.

Giovanni


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 18 guests