STM32F37x ADC vs SDADC clocks Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
dflogeras
Posts: 212
Joined: Tue Sep 03, 2013 8:16 pm
Has thanked: 7 times
Been thanked: 19 times

STM32F37x ADC vs SDADC clocks  Topic is solved

Postby dflogeras » Thu Oct 19, 2017 3:29 pm

Hi,

I'm using ChibiOS-16.x.y on a stm32f372. I'm currently using the SDADC to perform conversions, but this requires me to set HAL_USE_ADC.

The side effect I'm noticing is that I cannot scale the APB2 clock tree down as far as I'd like because it is requiring me to stay within the acceptable range for the ADC peripheral. Could this be addressed in a future version? Is there a technical reason I shouldn't be able to do this?

Thanks,
Dave

User avatar
Giovanni
Site Admin
Posts: 14455
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: STM32F37x ADC vs SDADC clocks

Postby Giovanni » Sat Oct 21, 2017 4:56 pm

Hi,

Moving this in "bug reports", this limitation is not intentional, probably the check should be modified.

Giovanni

User avatar
Giovanni
Site Admin
Posts: 14455
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: STM32F37x ADC vs SDADC clocks

Postby Giovanni » Sun May 27, 2018 9:04 am

bump

User avatar
Giovanni
Site Admin
Posts: 14455
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: STM32F37x ADC vs SDADC clocks

Postby Giovanni » Fri Jun 01, 2018 8:24 am

Hi,

I committed a change in trunk about this. Will backport if requested.

Giovanni

dflogeras
Posts: 212
Joined: Tue Sep 03, 2013 8:16 pm
Has thanked: 7 times
Been thanked: 19 times

Re: STM32F37x ADC vs SDADC clocks

Postby dflogeras » Sun Jun 10, 2018 2:50 am

Hey Giovanni, thanks for this patch

It looks like you may have a copy/paste error in 12060, you repeated SDADC1 three times, I bet you meant SDADC1 | SDADC2 | SDADC3.

User avatar
Giovanni
Site Admin
Posts: 14455
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: STM32F37x ADC vs SDADC clocks

Postby Giovanni » Sun Jun 10, 2018 5:14 am

Where exactly? I cannot find that.

Giovanni

dflogeras
Posts: 212
Joined: Tue Sep 03, 2013 8:16 pm
Has thanked: 7 times
Been thanked: 19 times

Re: STM32F37x ADC vs SDADC clocks

Postby dflogeras » Sun Jun 10, 2018 5:37 pm

Sorry about that, lines 856 and 862 of os/hal/ports/STM32/STM32F37x/hal_lld.h

https://sourceforge.net/p/chibios/svn2/12060/

dflogeras
Posts: 212
Joined: Tue Sep 03, 2013 8:16 pm
Has thanked: 7 times
Been thanked: 19 times

Re: STM32F37x ADC vs SDADC clocks

Postby dflogeras » Wed Aug 01, 2018 11:44 am

patch.zip
proposed fix
(600 Bytes) Downloaded 204 times

User avatar
Giovanni
Site Admin
Posts: 14455
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: STM32F37x ADC vs SDADC clocks

Postby Giovanni » Sun Aug 26, 2018 8:25 am

Hi,

Fixed as bug #974. There was also another small problem.

Giovanni


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 29 guests