ChibiOS 17.6.2 chmemcore.h: chCoreAlloc

Report here problems in any of ChibiOS components. This forum is NOT for support.
faisal
Posts: 25
Joined: Wed Jul 19, 2017 12:44 am
Has thanked: 4 times
Been thanked: 2 times

ChibiOS 17.6.2 chmemcore.h: chCoreAlloc

Postby faisal » Tue Oct 10, 2017 11:42 pm

Shouldn't chCoreAlloc() call chCoreAllocAlignedWithOffset, instead of the I-class function chCoreAllocAlignedWithOffsetI .

This sounds pretty fundamental ... I haven't looked at the tests yet that are run before each release, but any call of this outside a lock should should have triggered an assertion if they were enabled. I am a bit troubled by this, is there a reason I shouldn't be concerned?

** Edit: Just checked. There are no tests for chCoreAlloc . I believe there should be.

User avatar
Giovanni
Site Admin
Posts: 10134
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 205 times
Been thanked: 183 times
Contact:

Re: ChibiOS 17.6.2 chmemcore.h: chCoreAlloc

Postby Giovanni » Wed Oct 11, 2017 8:43 am

Hi,

Fixed as bug #896.

Giovanni

faisal
Posts: 25
Joined: Wed Jul 19, 2017 12:44 am
Has thanked: 4 times
Been thanked: 2 times

Re: ChibiOS 17.6.2 chmemcore.h: chCoreAlloc

Postby faisal » Wed Oct 11, 2017 1:27 pm

Giovanni wrote:Hi,

Fixed as bug #896.

Giovanni


Thank you Giovanni! Will you include some unit tests as well for chCoreAlloc and related code?

User avatar
Giovanni
Site Admin
Posts: 10134
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 205 times
Been thanked: 183 times
Contact:

Re: ChibiOS 17.6.2 chmemcore.h: chCoreAlloc

Postby Giovanni » Wed Oct 11, 2017 2:27 pm

At a later time.

Giovanni

faisal
Posts: 25
Joined: Wed Jul 19, 2017 12:44 am
Has thanked: 4 times
Been thanked: 2 times

Re: ChibiOS 17.6.2 chmemcore.h: chCoreAlloc

Postby faisal » Wed Oct 11, 2017 2:57 pm

Giovanni wrote:At a later time.

Giovanni


Got it, thanks. I do think it's an important module to have a test for.


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 1 guest