TIM2 Discrepancies in stm32_tim.c Topic is solved

Report here problems in any of ChibiOS components. This forum is NOT for support.
neums
Posts: 133
Joined: Fri May 08, 2015 1:09 pm
Location: Dresden, Germany
Has thanked: 10 times
Been thanked: 5 times

TIM2 Discrepancies in stm32_tim.c

Postby neums » Fri Apr 21, 2017 7:06 am

Hi,
there are serveral discrepancies in stm32_tim.c

1. There are two occurrences of function call "gpt_lld_serve_interrupt" with two different
function signatures.

Code: Select all

#if STM32_GPT_USE_TIM2
  gpt_lld_serve_interrupt(&GPTD2);
#endif

B)

Code: Select all

#if STM32_PWM_USE_TIM2
  gpt_lld_serve_interrupt(&PWMD2, sr);
#endif


I think that the second interrupt serve routine is wrong. That has to be pwm_lld_serve_interrupt.

2. Call to the function "icu_lld_serve_interrupt" is as follows (2 parameters):

Code: Select all

#if STM32_ICU_USE_TIM2
  icu_lld_serve_interrupt(&ICUD2, sr);
#endif


but the function is defined as

Code: Select all

void icu_lld_serve_interrupt(ICUDriver *icup);
in icu_lld.c which has just 1 parameter.

3.

Code: Select all

#if STM32_GPT_USE_TIM2
  st_lld_serve_interrupt();
#endif

This function is not defined at all.

User avatar
RoccoMarco
Posts: 528
Joined: Wed Apr 24, 2013 4:11 pm
Location: Salerno (Italy)
Has thanked: 63 times
Been thanked: 47 times
Contact:

Re: TIM2 Discrepancies in stm32_tim.c

Postby RoccoMarco » Fri Apr 21, 2017 8:04 am

Actually this file is not used. We forgot to remove it. Thanks for reporting.
Moving in bug reports.
Ciao,
RM

User avatar
RoccoMarco
Posts: 528
Joined: Wed Apr 24, 2013 4:11 pm
Location: Salerno (Italy)
Has thanked: 63 times
Been thanked: 47 times
Contact:

Re: TIM2 Discrepancies in stm32_tim.c  Topic is solved

Postby RoccoMarco » Sat Apr 22, 2017 2:09 pm

File removed.
Ciao,
RM


Return to “Bug Reports”

Who is online

Users browsing this forum: No registered users and 1 guest