[INFO] New style checker tool

This forum is dedicated to feedback, discussions about ongoing or future developments, ideas and suggestions regarding the ChibiOS projects are welcome. This forum is NOT for support.
User avatar
Giovanni
Site Admin
Posts: 13012
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 745 times
Been thanked: 621 times
Contact:

[INFO] New style checker tool

Postby Giovanni » Sat May 18, 2019 3:05 pm

Hi,

I added under /tools/style a small perl tool that is able to pick a lot of small style issues. useful when submitting code, it can check single files or whole subsystems.

It helped me fix a lot of small style issues in the code base.

It is not a general tool because it is hardwired on the ChibiOS style but feel free to customize and use it for your needs.

Giovanni

faisal
Posts: 260
Joined: Wed Jul 19, 2017 12:44 am
Has thanked: 35 times
Been thanked: 34 times

Re: [INFO] New style checker tool

Postby faisal » Thu May 23, 2019 3:44 pm

Have you had a chance to look into the various code style enforcement tools I emailed you about?

User avatar
Giovanni
Site Admin
Posts: 13012
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 745 times
Been thanked: 621 times
Contact:

Re: [INFO] New style checker tool

Postby Giovanni » Thu May 23, 2019 5:13 pm

Hi,

Yes, I am looking into it as a more general quality solution, however it is not addressing the kind of small "style errors" I am after right now. Anyway, we have the script for that now :)

Giovanni

User avatar
tfAteba
Posts: 526
Joined: Fri Oct 16, 2015 11:03 pm
Location: Chartres, France
Has thanked: 80 times
Been thanked: 46 times

Re: [INFO] New style checker tool

Postby tfAteba » Fri May 24, 2019 12:59 pm

Hey All,

I'm happy to see that this tools it evolve, I try to improve it two years ago but I have no notion in perl so I prefer after some improvement to continue to work on my C program.

But I will give a try and a feedbak is necessary.

Thanks.
regards,

Theo.

User avatar
Giovanni
Site Admin
Posts: 13012
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 745 times
Been thanked: 621 times
Contact:

Re: [INFO] New style checker tool

Postby Giovanni » Fri May 24, 2019 1:25 pm

Perl is not my thing either, probably an expert could have made it better.

Giovanni

meatball
Posts: 31
Joined: Thu May 19, 2016 4:39 pm
Has thanked: 9 times
Been thanked: 2 times

Re: [INFO] New style checker tool

Postby meatball » Tue Jun 04, 2019 4:16 am

Have you used uncrustify? It's multiplatform, and is widely configurable. I'm sure it wouldn't be too hard to setup a config file and add it to the repo. You can try it here: https://cdanu.github.io/uncrustify_conf ... index.html

User avatar
Giovanni
Site Admin
Posts: 13012
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 745 times
Been thanked: 621 times
Contact:

Re: [INFO] New style checker tool

Postby Giovanni » Tue Jun 04, 2019 4:45 am

Hi,

Interesting, if is far more advanced but it is not exactly what I was trying to do. Mainly it is a formatter, I just wanted a checker able to operate on the whole codebase in one go. In addition it does not check for some kind of details I am interested in, like stye of comments, vertical spacing etc.

Giovanni

mobyfab
Posts: 451
Joined: Sat Nov 19, 2011 6:47 pm
Location: Versailles, France
Has thanked: 12 times
Been thanked: 17 times

Re: [INFO] New style checker tool

Postby mobyfab » Tue Jun 04, 2019 3:00 pm



Return to “Development and Feedback”

Who is online

Users browsing this forum: No registered users and 7 guests