Migration - retired definitions

This forum is dedicated to feedback, discussions about ongoing or future developments, ideas and suggestions regarding the ChibiOS projects are welcome. This forum is NOT for support.
steved
Posts: 825
Joined: Fri Nov 09, 2012 2:22 pm
Has thanked: 12 times
Been thanked: 135 times

Migration - retired definitions

Postby steved » Sat Mar 03, 2018 1:46 pm

When a definition is withdrawn or changed, would it be possible to flag that as an error to highlight the change? Could speed up transitions between versions. (Maybe list all in a separate file or files, included by default. If it adds significantly to compile time, have an option to bypass the file)

(I've just spent quite a while tracking down that STM32_EXTI_LINE2_3_HANDLER is no longer valid - maybe it was flagged somewhere in the release notes for the transition to 16.x to 17.x, but that was a long time ago)

User avatar
Giovanni
Site Admin
Posts: 14457
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1076 times
Been thanked: 922 times
Contact:

Re: Migration - retired definitions

Postby Giovanni » Wed Mar 14, 2018 4:49 pm

Hi,

Addressed with an updater tool added to trunk.

Giovanni

steved
Posts: 825
Joined: Fri Nov 09, 2012 2:22 pm
Has thanked: 12 times
Been thanked: 135 times

Re: Migration - retired definitions

Postby steved » Wed Mar 14, 2018 9:57 pm

Giovanni wrote:Hi,

Addressed with an updater tool added to trunk.

Giovanni

Having looked into this a bit more, things do not appear to be as I first thought. I presumably got the label STM32_EXTI_LINE2_3_HANDLER from somewhere, although I can't find from where (I'm using the F091, and there is a very similar definition in the L0XX processor range). And the code compiled without error when using it. Perhaps its down to the way OSAL_IRQ_HANDLER(STM32_EXTI_LINE2_3_HANDLER) is handled - STM32_EXTI_LINE2_3_HANDLER is just given the value zero, hence a crash on an EXTI interrupt.

So the ideal would be able to detect invalid #define values passed to macros - not straightforward, I suspect.


Return to “Development and Feedback”

Who is online

Users browsing this forum: No registered users and 64 guests