GPL contribution: SSL integration

[danielinux]

Hello,

First time contributor.

I've developed a HTTPS demo (based on the F7's HTTP demo) which shows how to create a HTTPS server using wolfSSL.

The demo requires to link against wolfSSL (in ext/wolfssl). I have also prepared the required binding functions, and placed under os/various/wolfssl_bindings, using the same logic as for the lwip integration.

I am finalizing the documentation (README in the app directory), then I would like to submit this to your attention. What is the tree I should rebase my patch on? Should I send a patch here, or is there another way to submit contributions (e.g. a pull request mechanism)?

Thanks in advance,

--
Daniele "danielinux" Lacamera

[tfAteba]

Hello Daniele,

Thanks for your interrest and for your contribution.

Your work can be base on trunk branch because this is the one used for developments and tests purpose.

You can send a patch here so that Giovanni will integrate it to the trunk if every things looks good

Thanks.

[steved]

As a matter of interest, how does wolfSSL compare with openSSL at the software level?

(I had a quick look at licensing, and wolfSSL's licensing model could be prohibitively costly for some commercial applications, while openSSL has an Apache licence)

[Giovanni]

Hi,

Posting a patch on the forum is fine. I recommend to prepare a zip file to be located into ./ext like lwIP and FatFS and a demo to be placed under ./demos.

Giovanni

[danielinux]

ChibiOS-svn-r10962-wolfSSL_support.patch.zip

compressed diff, applies on svn r10962

(2.18 MiB) Downloaded 173 times

Here is the patch. Comments welcome.

Code is structured as indicated:

- ext/ contains a 7z archive of a "patched" wolfSSL. The settings needed will be anyway integrated in upstream wolfSSL, so it will be possible to link against unmodified git versions as soon as this gets integrated

- os/various/wolfssl_bindings contains the glue code

- demo app for STM32F746-discovery in its own directory, based on Chibios 17.x http example, which serves HTTPS connections on port 443.

[Giovanni]

Good work.

Is the patch for 17.6 or trunk?

Giovanni

[danielinux]

Is the patch for 17.6 or trunk?

it's for trunk, applies on r10962

[danielinux]

Hello!
Any more comments on this? Would you consider it for merging as is, or do you see anything that need to be changed?

[Giovanni]

Hi,

It will be merged in trunk ASAP.

Giovanni

[danielinux]

FYI:
The changes needed on wolfSSL side are on their way in a pull request on github:
https://github.com/wolfSSL/wolfssl/pull/1245