GPL contribution: SSL integration

This forum is dedicated to feedback, discussions about ongoing or future developments, ideas and suggestions regarding the ChibiOS projects are welcome.
User avatar
danielinux
Posts: 11
Joined: Sat Nov 04, 2017 12:38 pm
Location: Somewhere in Belgium
Has thanked: 4 times

GPL contribution: SSL integration

Postby danielinux » Sat Nov 04, 2017 12:44 pm

Hello,

First time contributor.

I've developed a HTTPS demo (based on the F7's HTTP demo) which shows how to create a HTTPS server using wolfSSL.

The demo requires to link against wolfSSL (in ext/wolfssl). I have also prepared the required binding functions, and placed under os/various/wolfssl_bindings, using the same logic as for the lwip integration.

I am finalizing the documentation (README in the app directory), then I would like to submit this to your attention. What is the tree I should rebase my patch on? Should I send a patch here, or is there another way to submit contributions (e.g. a pull request mechanism)?

Thanks in advance,

--
Daniele "danielinux" Lacamera

User avatar
tfAteba
Posts: 422
Joined: Fri Oct 16, 2015 11:03 pm
Location: Chartres, France
Has thanked: 55 times
Been thanked: 29 times

Re: GPL contribution: SSL integration

Postby tfAteba » Sat Nov 04, 2017 1:31 pm

Hello Daniele,

Thanks for your interrest and for your contribution.

Your work can be base on trunk branch because this is the one used for developments and tests purpose.

You can send a patch here so that Giovanni will integrate it to the trunk if every things looks good :)

Thanks.
regards,

Theo.

steved
Posts: 456
Joined: Fri Nov 09, 2012 2:22 pm
Has thanked: 3 times
Been thanked: 34 times

Re: GPL contribution: SSL integration

Postby steved » Sat Nov 04, 2017 1:32 pm

As a matter of interest, how does wolfSSL compare with openSSL at the software level?

(I had a quick look at licensing, and wolfSSL's licensing model could be prohibitively costly for some commercial applications, while openSSL has an Apache licence)

User avatar
Giovanni
Site Admin
Posts: 10341
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 231 times
Been thanked: 205 times
Contact:

Re: GPL contribution: SSL integration

Postby Giovanni » Sat Nov 04, 2017 2:31 pm

Hi,

Posting a patch on the forum is fine. I recommend to prepare a zip file to be located into ./ext like lwIP and FatFS and a demo to be placed under ./demos.

Giovanni

User avatar
danielinux
Posts: 11
Joined: Sat Nov 04, 2017 12:38 pm
Location: Somewhere in Belgium
Has thanked: 4 times

Re: GPL contribution: SSL integration

Postby danielinux » Tue Nov 07, 2017 5:48 pm

ChibiOS-svn-r10962-wolfSSL_support.patch.zip
compressed diff, applies on svn r10962
(2.18 MiB) Downloaded 10 times

Here is the patch. Comments welcome.

Code is structured as indicated:

- ext/ contains a 7z archive of a "patched" wolfSSL. The settings needed will be anyway integrated in upstream wolfSSL, so it will be possible to link against unmodified git versions as soon as this gets integrated

- os/various/wolfssl_bindings contains the glue code

- demo app for STM32F746-discovery in its own directory, based on Chibios 17.x http example, which serves HTTPS connections on port 443.

User avatar
Giovanni
Site Admin
Posts: 10341
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 231 times
Been thanked: 205 times
Contact:

Re: GPL contribution: SSL integration

Postby Giovanni » Wed Nov 08, 2017 12:18 pm

Good work.

Is the patch for 17.6 or trunk?

Giovanni

User avatar
danielinux
Posts: 11
Joined: Sat Nov 04, 2017 12:38 pm
Location: Somewhere in Belgium
Has thanked: 4 times

Re: GPL contribution: SSL integration

Postby danielinux » Wed Nov 08, 2017 1:03 pm

Is the patch for 17.6 or trunk?


it's for trunk, applies on r10962

User avatar
danielinux
Posts: 11
Joined: Sat Nov 04, 2017 12:38 pm
Location: Somewhere in Belgium
Has thanked: 4 times

Re: GPL contribution: SSL integration

Postby danielinux » Mon Nov 13, 2017 9:16 am

Hello!
Any more comments on this? Would you consider it for merging as is, or do you see anything that need to be changed?

User avatar
Giovanni
Site Admin
Posts: 10341
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 231 times
Been thanked: 205 times
Contact:

Re: GPL contribution: SSL integration

Postby Giovanni » Mon Nov 13, 2017 9:25 am

Hi,

It will be merged in trunk ASAP.

Giovanni

User avatar
danielinux
Posts: 11
Joined: Sat Nov 04, 2017 12:38 pm
Location: Somewhere in Belgium
Has thanked: 4 times

Re: GPL contribution: SSL integration

Postby danielinux » Tue Nov 21, 2017 8:05 pm

FYI:
The changes needed on wolfSSL side are on their way in a pull request on github:
https://github.com/wolfSSL/wolfssl/pull/1245


Return to “Development and Feedback”

Who is online

Users browsing this forum: No registered users and 1 guest