GPL contribution: SSL integration

This forum is dedicated to feedback, discussions about ongoing or future developments, ideas and suggestions regarding the ChibiOS projects are welcome. This forum is NOT for support.
User avatar
Giovanni
Site Admin
Posts: 14444
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1074 times
Been thanked: 921 times
Contact:

Re: GPL contribution: SSL integration

Postby Giovanni » Tue Nov 21, 2017 10:19 pm

Thanks.

Giovanni

User avatar
danielinux
Posts: 20
Joined: Sat Nov 04, 2017 12:38 pm
Location: Amsterdam, The Netherlands
Has thanked: 4 times
Been thanked: 2 times

Re: GPL contribution: SSL integration

Postby danielinux » Mon Dec 04, 2017 9:42 am

Any news about this?

User avatar
Giovanni
Site Admin
Posts: 14444
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1074 times
Been thanked: 921 times
Contact:

Re: GPL contribution: SSL integration

Postby Giovanni » Mon Dec 04, 2017 9:46 am

Hi,

It is not clear to me, do I have to wait for those changes to be integrated first or I can proceed with exactly what you posted?

Giovanni

User avatar
danielinux
Posts: 20
Joined: Sat Nov 04, 2017 12:38 pm
Location: Amsterdam, The Netherlands
Has thanked: 4 times
Been thanked: 2 times

Re: GPL contribution: SSL integration

Postby danielinux » Mon Dec 04, 2017 10:21 am

Hi,

you can proceed and integrate the patch I posted earlier, as the (patched) third party library in ext works fine.

The changes will be integrated in wolfSSL upstream, meaning that we will be able to easily upgrade by just putting a new archive in place, and security updates won't require any specific patching to wolfSSL code.

Sorry about the confusion. Please proceed with merging if the patch is OK for you.

Thanks,

--
Daniele

User avatar
danielinux
Posts: 20
Joined: Sat Nov 04, 2017 12:38 pm
Location: Amsterdam, The Netherlands
Has thanked: 4 times
Been thanked: 2 times

Re: GPL contribution: SSL integration

Postby danielinux » Fri Dec 15, 2017 2:44 pm

perhaps that one is outdated by now. Do you want me to prepare a new patch on the latest trunk?

User avatar
Giovanni
Site Admin
Posts: 14444
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1074 times
Been thanked: 921 times
Contact:

Re: GPL contribution: SSL integration

Postby Giovanni » Fri Dec 15, 2017 2:47 pm

I was going to integrate during weekend, can you do this by Sunday? if not I will reintegrate after changes are ready.

The package is going to be released in 18.1.0 so we still have more than a month to finalize it.

Giovanni

User avatar
danielinux
Posts: 20
Joined: Sat Nov 04, 2017 12:38 pm
Location: Amsterdam, The Netherlands
Has thanked: 4 times
Been thanked: 2 times

Re: GPL contribution: SSL integration

Postby danielinux » Fri Dec 15, 2017 4:55 pm

yes, I will just rebase on the current trunk. I've also spotted a typo in a comment, which I will fix. Will post a fresh patch later or tomorrow.

Thanks!

User avatar
danielinux
Posts: 20
Joined: Sat Nov 04, 2017 12:38 pm
Location: Amsterdam, The Netherlands
Has thanked: 4 times
Been thanked: 2 times

Re: GPL contribution: SSL integration

Postby danielinux » Sat Dec 16, 2017 2:50 pm

Here is the new patch applying on r11142.

ChibiOS-svn-r11142-wolfSSL_support.patch.zip
(43.96 KiB) Downloaded 165 times


Please go ahead with merging if you think it's OK. There are no changes from the previous patch, except a typo was fixed in the comments, and I ensured it cleanly applies on latest trunk.

Thanks,

/d

User avatar
Giovanni
Site Admin
Posts: 14444
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 1074 times
Been thanked: 921 times
Contact:

Re: GPL contribution: SSL integration

Postby Giovanni » Sat Dec 16, 2017 5:34 pm

Hi,

I merged the patch, few changes:

- WolfSSL was in the old patch not new one.
- Normalized some makefile settings.
- Added Eclipse project files.
- Added our normal debug files.
- Configuration files were not up to date, took them from another demo.
- Added something to wolfssl.mk, new variables used by the enhanced build.

Now it seems to compile correctly, there is a warning in asn.c, is this normal?

Giovanni

User avatar
danielinux
Posts: 20
Joined: Sat Nov 04, 2017 12:38 pm
Location: Amsterdam, The Netherlands
Has thanked: 4 times
Been thanked: 2 times

Re: GPL contribution: SSL integration

Postby danielinux » Sun Dec 17, 2017 11:01 am

Thanks for taking the time to fix and merge in.

The following patch fixes the warning about the missing declaration, thanks for spotting this.

wolfssl-warning-hotfix.patch.zip
(556 Bytes) Downloaded 187 times


I tested the HTTPS demo from trunk on my F746 and everything works as expected.


Return to “Development and Feedback”

Who is online

Users browsing this forum: No registered users and 17 guests