Thanks.
Giovanni
GPL contribution: SSL integration
- Giovanni
- Site Admin
- Posts: 14444
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1074 times
- Been thanked: 921 times
- Contact:
- danielinux
- Posts: 20
- Joined: Sat Nov 04, 2017 12:38 pm
- Location: Amsterdam, The Netherlands
- Has thanked: 4 times
- Been thanked: 2 times
- Giovanni
- Site Admin
- Posts: 14444
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1074 times
- Been thanked: 921 times
- Contact:
Re: GPL contribution: SSL integration
Hi,
It is not clear to me, do I have to wait for those changes to be integrated first or I can proceed with exactly what you posted?
Giovanni
It is not clear to me, do I have to wait for those changes to be integrated first or I can proceed with exactly what you posted?
Giovanni
- danielinux
- Posts: 20
- Joined: Sat Nov 04, 2017 12:38 pm
- Location: Amsterdam, The Netherlands
- Has thanked: 4 times
- Been thanked: 2 times
Re: GPL contribution: SSL integration
Hi,
you can proceed and integrate the patch I posted earlier, as the (patched) third party library in ext works fine.
The changes will be integrated in wolfSSL upstream, meaning that we will be able to easily upgrade by just putting a new archive in place, and security updates won't require any specific patching to wolfSSL code.
Sorry about the confusion. Please proceed with merging if the patch is OK for you.
Thanks,
--
Daniele
you can proceed and integrate the patch I posted earlier, as the (patched) third party library in ext works fine.
The changes will be integrated in wolfSSL upstream, meaning that we will be able to easily upgrade by just putting a new archive in place, and security updates won't require any specific patching to wolfSSL code.
Sorry about the confusion. Please proceed with merging if the patch is OK for you.
Thanks,
--
Daniele
- danielinux
- Posts: 20
- Joined: Sat Nov 04, 2017 12:38 pm
- Location: Amsterdam, The Netherlands
- Has thanked: 4 times
- Been thanked: 2 times
Re: GPL contribution: SSL integration
perhaps that one is outdated by now. Do you want me to prepare a new patch on the latest trunk?
- Giovanni
- Site Admin
- Posts: 14444
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1074 times
- Been thanked: 921 times
- Contact:
Re: GPL contribution: SSL integration
I was going to integrate during weekend, can you do this by Sunday? if not I will reintegrate after changes are ready.
The package is going to be released in 18.1.0 so we still have more than a month to finalize it.
Giovanni
The package is going to be released in 18.1.0 so we still have more than a month to finalize it.
Giovanni
- danielinux
- Posts: 20
- Joined: Sat Nov 04, 2017 12:38 pm
- Location: Amsterdam, The Netherlands
- Has thanked: 4 times
- Been thanked: 2 times
Re: GPL contribution: SSL integration
yes, I will just rebase on the current trunk. I've also spotted a typo in a comment, which I will fix. Will post a fresh patch later or tomorrow.
Thanks!
Thanks!
- danielinux
- Posts: 20
- Joined: Sat Nov 04, 2017 12:38 pm
- Location: Amsterdam, The Netherlands
- Has thanked: 4 times
- Been thanked: 2 times
Re: GPL contribution: SSL integration
Here is the new patch applying on r11142.
Please go ahead with merging if you think it's OK. There are no changes from the previous patch, except a typo was fixed in the comments, and I ensured it cleanly applies on latest trunk.
Thanks,
/d
Please go ahead with merging if you think it's OK. There are no changes from the previous patch, except a typo was fixed in the comments, and I ensured it cleanly applies on latest trunk.
Thanks,
/d
- Giovanni
- Site Admin
- Posts: 14444
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1074 times
- Been thanked: 921 times
- Contact:
Re: GPL contribution: SSL integration
Hi,
I merged the patch, few changes:
- WolfSSL was in the old patch not new one.
- Normalized some makefile settings.
- Added Eclipse project files.
- Added our normal debug files.
- Configuration files were not up to date, took them from another demo.
- Added something to wolfssl.mk, new variables used by the enhanced build.
Now it seems to compile correctly, there is a warning in asn.c, is this normal?
Giovanni
I merged the patch, few changes:
- WolfSSL was in the old patch not new one.
- Normalized some makefile settings.
- Added Eclipse project files.
- Added our normal debug files.
- Configuration files were not up to date, took them from another demo.
- Added something to wolfssl.mk, new variables used by the enhanced build.
Now it seems to compile correctly, there is a warning in asn.c, is this normal?
Giovanni
- danielinux
- Posts: 20
- Joined: Sat Nov 04, 2017 12:38 pm
- Location: Amsterdam, The Netherlands
- Has thanked: 4 times
- Been thanked: 2 times
Re: GPL contribution: SSL integration
Thanks for taking the time to fix and merge in.
The following patch fixes the warning about the missing declaration, thanks for spotting this.
I tested the HTTPS demo from trunk on my F746 and everything works as expected.
The following patch fixes the warning about the missing declaration, thanks for spotting this.
I tested the HTTPS demo from trunk on my F746 and everything works as expected.
Return to “Development and Feedback”
Who is online
Users browsing this forum: No registered users and 17 guests