Hi,
One important problem with HAL is that it uses very generic file names like adc.c, can.h etc. This can create problems when integrating 3rd parties libraries that may use the same names.
Because of this, in HAL 5.0 all file names will be prefixed by "hal_", high level files have already been renamed because there is no impact on ports but also low level files will have to be renamed at some point.
All maintainers please prepare for the transition, I will start with STM32 of course.
Giovanni
[INFO] HAL files renaming
- Giovanni
- Site Admin
- Posts: 14455
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1076 times
- Been thanked: 922 times
- Contact:
Re: [INFO] HAL files renaming
Good news. It was always bother me when I want to create wrapper on ADC (launch, convertion, etc.) and can not name it just "adc".
- Giovanni
- Site Admin
- Posts: 14455
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1076 times
- Been thanked: 922 times
- Contact:
Re: [INFO] HAL files renaming
Yes, same here. I want to address all those small annoying things before next release. If there are more please propose changes.
Giovanni
Giovanni
Re: [INFO] HAL files renaming
Yet another bothering moment is lots of copypaste code in testhal applications.
Did you think about moving of common high level code to separate application
and call it from testhals after platform dependant peripheral init?
Did you think about moving of common high level code to separate application
and call it from testhals after platform dependant peripheral init?
- Giovanni
- Site Admin
- Posts: 14455
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1076 times
- Been thanked: 922 times
- Contact:
- Giovanni
- Site Admin
- Posts: 14455
- Joined: Wed May 27, 2009 8:48 am
- Location: Salerno, Italy
- Has thanked: 1076 times
- Been thanked: 922 times
- Contact:
Re: [INFO] HAL files renaming
Hi,
I renamed files for STM32, LPC214x, AVR and simulator HAL ports. Code in the community repository or other repositories should be updated in a similar way, basically:
1) Prefix LLD file names with hal_, for example from adc_lld.h to hal_lld_adc.h.
2) Change the header guards from _XXXXXX_H_ to XXXXXX_H because some checkers are complaining about _ prefix being reserved. This is optional, up to you.
Giovanni
I renamed files for STM32, LPC214x, AVR and simulator HAL ports. Code in the community repository or other repositories should be updated in a similar way, basically:
1) Prefix LLD file names with hal_, for example from adc_lld.h to hal_lld_adc.h.
2) Change the header guards from _XXXXXX_H_ to XXXXXX_H because some checkers are complaining about _ prefix being reserved. This is optional, up to you.
Giovanni
Return to “Development and Feedback”
Who is online
Users browsing this forum: No registered users and 17 guests