SPI driver improvements Topic is solved

ChibiOS public support forum for topics related to the Atmel AVR family of micro-controllers.

Moderators: utzig, tfAteba

User avatar
tfAteba
Posts: 513
Joined: Fri Oct 16, 2015 11:03 pm
Location: Chartres, France
Has thanked: 75 times
Been thanked: 44 times

Re: SPI driver improvements

Postby tfAteba » Fri Sep 01, 2017 11:49 pm

I have just made a couple of small modifications to your work such as removing trailing spaces, and correct some header files in order to match other drivers.

I have also update the file testhal/AVR/MEGA/SPI/main.c with the new SPI configuration according your patch.
This test hal demo still need to be tested :) for the moment I just build it.

So now your work is applied to trunk.
regards,

Theo.

User avatar
Giovanni
Site Admin
Posts: 11307
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 412 times
Been thanked: 342 times
Contact:

Re: SPI driver improvements

Postby Giovanni » Sat Sep 02, 2017 7:39 am

tfAteba wrote:He must have is reasons :)


Very simple, I hate git.

Giovanni

Marco
Posts: 128
Joined: Tue Apr 16, 2013 8:22 pm
Has thanked: 4 times
Been thanked: 11 times

Re: SPI driver improvements  Topic is solved

Postby Marco » Mon Sep 04, 2017 4:30 pm

Hi,

Thanks for merging tfAteba!

@Giovanni, I respect your opinion. But what is it you hate about it?

Marco

User avatar
Giovanni
Site Admin
Posts: 11307
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 412 times
Been thanked: 342 times
Contact:

Re: SPI driver improvements

Postby Giovanni » Mon Sep 04, 2017 4:41 pm

You could start from here https://svnvsgit.com but it does not address all problems.

Giovanni

utzig
Posts: 354
Joined: Sat Jan 07, 2012 6:22 pm
Location: Brazil
Has thanked: 1 time
Been thanked: 16 times
Contact:

Re: SPI driver improvements

Postby utzig » Mon Sep 04, 2017 5:19 pm

LOL, also there are "white supremacy" web sites, so whites are better!!! My point being, I get that taste is personal and I respect it, but srsly that site is full of BS!

Marco
Posts: 128
Joined: Tue Apr 16, 2013 8:22 pm
Has thanked: 4 times
Been thanked: 11 times

Re: SPI driver improvements

Postby Marco » Mon Sep 04, 2017 8:51 pm

Interesting page. I just think contribution to a SVN repository is more combersome than contributing to Git repositories, which was the reason to start this discussion. Both work, they are just different.

This is going a bit offtopic, so maybe this should be split up if we want to continue to discuss ;)


Return to “AVR Support”

Who is online

Users browsing this forum: No registered users and 2 guests