SPI Write Collision

[Marco]

Hi,

I found a bug in the AVR SPI driver.

When doing multiple multi-byte SPI write operations, the Write Collision Flag (WCOL) bit in SPI Status Register (SPSR) gets set.
This is caused by calling

Code: Select all

_spi_isr_code(spip);

while the transmission is still in progress.

Attached is a patch to fix this issue.

Marco

[utzig]

That patch doesn't seem to have been created against trunk. What version are you using?

[Marco]

No i'm sorry. I'm using the git mirror at commit 11eb96e. (svn://svn.code.sf.net/p/chibios/svn/trunk@9759).

Attached is the patch created against trunk.

[utzig]

Both patches apply the same changes.

[Marco]

Yes, i just recreated the patch with TortoiseSVN on the SVN trunk. The changes are the same.

[utzig]

The problem seemed to arrive from using patch on Mac OS X with CRLF line endings...

Applied, thanks!