Bug in ext_lld.c?

ChibiOS public support forum for topics related to the Atmel AT91SAM7x family of micro-controllers.

Moderator: inmarket

User avatar
lilvinz
Posts: 103
Joined: Sat Dec 21, 2013 2:56 pm
Has thanked: 1 time
Been thanked: 1 time

Bug in ext_lld.c?

Postby lilvinz » Thu Nov 13, 2014 11:37 am

Hi,

for STM32, ext callbacks are execute without system lock, this driver sets a system lock before invoking callbacks.
I assume this to be a bug as it prevents portability between platforms.
Can someone please confirm this?

Cheers,

Vinz

User avatar
Giovanni
Site Admin
Posts: 9603
Joined: Wed May 27, 2009 8:48 am
Location: Salerno, Italy
Has thanked: 127 times
Been thanked: 120 times
Contact:

Re: Bug in ext_lld.c?

Postby Giovanni » Thu Nov 13, 2014 12:08 pm

By convention callbacks should be called outside critical zones, it would be a bug.

Giovanni

User avatar
lilvinz
Posts: 103
Joined: Sat Dec 21, 2013 2:56 pm
Has thanked: 1 time
Been thanked: 1 time

Re: Bug in ext_lld.c?

Postby lilvinz » Thu Nov 13, 2014 12:11 pm

Thanks for the quick reply.
The fix seems easy as i don't see a reason for the driver to enter a lock zone anyway.

Cheers,

Vinz


Return to “AT91SAM7x Support”

Who is online

Users browsing this forum: No registered users and 1 guest