chprintf argument warning message

[rew]

I'm starting to use chprintf again. (stupid of me to try to prevent the code bloat because now I'm spending brain-cycles on stuff that is better done by a computer).

But I get this warning:

Code: Select all

In file included from main.c:20:0:
../ChibiOS_2.6.6/os/various/chprintf.h:69:20: note: expected 'struct BaseSequentialStream *' but argument is of type 'struct BaseSequentialStream *'
 static INLINE void chprintf(BaseSequentialStream *chp, const char *fmt, ...) {


The cast was initially put in my code as a copy-paste from the warning message as to what it wanted. But the warning doesn't go away and now it doesn't make sense...

What am I missing?

[Giovanni]

I would verify the order of inclusions in your main.c,

Giovanni

[rew]

I verified it. But each time I look it stays in the same order.

Code: Select all

#include "ch.h"
#include "hal.h"
#include "chprintf.h"

#include "string.h"
//#include <stdio.h>
#include "stdlib.h"
#include "stdarg.h"

#include "cmds.h"
#include "cmds_prototypes.h"
#include "cmds_table.h"

#include "bits.h"
#include "main.h"
#include "ow.h"



This order seems to be the same that demos use: first ch, then hal then chprintf. After the std... includes are my own.

[Giovanni]

Just a suggestion, put the standard headers first using the angular brackets < >.

Can you post your call to chprintf? I don't see that warning in my examples. Does this occur to you also on the provided demos?

Giovanni

[colin]

Are there multiple BaseSequentialStream types in that version of ChibiOS? I think at some point there was one in the HAL and one in the RT kernel. Maybe gcc is confused.

Also is there more of the error message missing? It says "note:" which usually follows an actual warning or error message from gcc.

[Giovanni]

The one in HAL is not used where the HAL is used with RT, that *should* not be the problem.

Giovanni

[rew]

My "stdxxx.h" includes are now above the chibios includes. They now use angled brackets.

Code: Select all

In file included from main.c:31:0:
main.c: In function 'sd2puts':
main.h:118:26: warning: passing argument 1 of 'chprintf' from incompatible pointer type [enabled by default]
 #define ESP     ((struct BaseSequentialStream *)&SD2)
                          ^
main.c:460:13: note: in expansion of macro 'ESP'
   chprintf (ESP, "%s", p);
             ^
In file included from main.c:25:0:
../ChibiOS_2.6.6/os/various/chprintf.h:69:20: note: expected 'struct BaseSequentialStream *' but argument is of type 'struct BaseSequentialStream *'
 static INLINE void chprintf(BaseSequentialStream *chp, const char *fmt, ...) {
                    ^


The "sd2puts" used to call the write to sd2 directly, but while converting to use chprintf, I have this compatibility function that just prints the string using the "new" method...

Giovanni, the message should read something like: "expected 'float *' but argument is of type 'int *'", but apparently the types are different, but the textual representation for the warning message is the same.

So, your suggestion that it SHOULD not be the problem makes me suspicious that it actually IS the problem.

Well... My suspicions were wrong.... Searching for the definition(s) of BaseSequentialStream, I saw examples that used a cast to "(BaseSequentialStream *)&SDU1" instead of the "struct BaseSequentialStream *" that I was using.... I had copied the type from the warning message of gcc instead of from an example. Aaargh!

Correcting the casts and types resulted in many less warnings, leaving just a couple, where one was an actual bug that needed fixing....

Thanks for your help by the way!!