Search found 128 matches

by Marco
Fri Sep 01, 2017 3:59 pm
Forum: AVR Support
Topic: SPI driver improvements Topic is solved
Replies: 15
Views: 31902

Re: SPI driver improvements Topic is solved

Hi, The patches are based on an older version of trunk, before tfAteba made changes to the structure. The patches were made using git, but they should also apply on svn i guess. I'll just send the whole files so you can replace them to see the diffs. See attached zip. Hopefully it will be possible t...
by Marco
Wed Aug 30, 2017 10:45 pm
Forum: Development and Feedback
Topic: [INFO] ChibiOS 10 years anniversary and Event
Replies: 14
Views: 9893

Re: [INFO] ChibiOS 10 years anniversary and Event

Hi Giovanni,

Any news about the event? Is it still planned?

Marco
by Marco
Wed Aug 30, 2017 11:29 am
Forum: AVR Support
Topic: SPI driver improvements Topic is solved
Replies: 15
Views: 31902

Re: SPI driver improvements Topic is solved

Hi, I noticed the spi_lld_start function could be optimized more, like the STM32 port does. The 'intelligence' is removed and the function just writes the configuration to the registers. This saves 1 byte of RAM per configuration structure and roughly 150 bytes of FLASH. Attached is the new patch wh...
by Marco
Tue Aug 29, 2017 2:10 pm
Forum: AVR Support
Topic: SPI driver improvements Topic is solved
Replies: 15
Views: 31902

SPI driver improvements Topic is solved

Hi, I found some problems in the AVR SPI driver. 1) There is a bug in spi_lld_start(), the SPI interrupt is enabled before the peripheral has been configured properly. This can cause an unwanted interrupt. 2) For some reason, the MSTR bit gets cleared when set individually when the \SS pin is config...
by Marco
Sun Aug 27, 2017 3:34 pm
Forum: AVR Support
Topic: [PATCH] AVR EXT Topic is solved
Replies: 80
Views: 67319

Re: [PATCH] AVR EXT Topic is solved

Hi tfAfteba, Thank you for testing the attached files of my last post. I replaced the interrupt handler declarations for both PCINT and INT. I guess there are some differences between the atmega162 and atmega2560. Unfortunately I don't have any other mcu to test on :( Maybe you can debug both versio...
by Marco
Fri Aug 25, 2017 10:02 am
Forum: AVR Support
Topic: [PATCH] AVR EXT Topic is solved
Replies: 80
Views: 67319

Re: [PATCH] AVR EXT Topic is solved

Hi Marco, I hope I will have time to work on it this weekend. Marco wrote: I think (not tested) it is enough to replace this code block: Did you have the board and can you make the test? It will be helpful. Hi tfAteba, Attached are hal_ext_lld.c and hal_ext_lld.h which support both INT and PCINT in...
by Marco
Tue Aug 22, 2017 4:00 pm
Forum: AVR Support
Topic: [PATCH] AVR EXT Topic is solved
Replies: 80
Views: 67319

Re: [PATCH] AVR EXT Topic is solved

Hi, Sad to see the patch got reverted but logical since it was not working for INTx interrupts.. I see MGeo identified the problem in this post. I think when the 'Interrupt handlers for INT-type interrupts.' is rewritten correctly both PCINTx and INTx should work. I think (not tested) it is enough t...
by Marco
Tue Aug 22, 2017 2:13 pm
Forum: STM32 Support
Topic: I2C and Multithreading problem Topic is solved
Replies: 8
Views: 4018

Re: I2C and Multithreading problem Topic is solved

Hi,

You should yield from the main loop, for example with chThdSleepMilliseconds(1000). Otherwise the main loop starves the other thread.

Marco
by Marco
Mon Aug 21, 2017 10:50 am
Forum: Development and Feedback
Topic: [NOTE] HAL 6 and OSAL Evolutions
Replies: 12
Views: 10271

Re: [NOTE] HAL 6 and OSAL Evolutions

It is a way too specific use case and it would be problematic to implement too, the spiSelect() and spiUnselect() functions are meant to be callable from any context (thread and ISR) while the I2C driver can only be used from thread context being synchronous. Giovanni I understand. I didn't pay att...
by Marco
Tue Aug 15, 2017 4:00 pm
Forum: Development and Feedback
Topic: [NOTE] HAL 6 and OSAL Evolutions
Replies: 12
Views: 10271

Re: [NOTE] HAL 6 and OSAL Evolutions

Hi Marco, We already have iolines in PAL, the SPI implementations should be updated to use that instead of port/pad, a fallback mode is also required. Adding it to the list. Giovanni Hi Giovanni, I know, and i already use them in the Tiva testhal and demo applications, but it is not abstract enough...

Go to advanced search