Search found 130 matches

by tridge
Tue Nov 26, 2019 6:18 am
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

I left my test harness running and have now found yet another I2Cv1 situation where we can do DMA outside a I2C transaction context. It is possible to generate both event and error interrupts when not in an I2C transaction if you have sufficient bus noise. This can lead to the ISR re-enabling an old...
by tridge
Tue Nov 26, 2019 4:36 am
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

After a couple of days of debugging I finally found the cause of the watchdog reset that I reported. It turns out that the interrupt storm reset using RCC is fine, it is an existing bug in the I2Cv1 driver. The bug is caused by leaving DMA rx enabled on a MSG_RESET return which can be triggered by a...
by tridge
Mon Nov 25, 2019 1:27 pm
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

Good point, this may need working with GPIO in order to do that. would you be interested in bringing palReadLineMode() into ChibiOS in some form? The code is here: https://github.com/ardupilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/common/stm32_util.c#L329 we use it in several places ...
by tridge
Mon Nov 25, 2019 1:25 pm
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

Hi, I'm currently investigating this issue: https://github.com/ArduPilot/ardupilot/issues/12760 where i2c interrupt storm is our main hypothesis at the moment. note that the firmware that is referenced in that issue didn't have the interrupt storm fix for BTF and didn't have the code to detect inte...
by tridge
Mon Nov 25, 2019 1:20 pm
Forum: STM32 Support
Topic: Where to start STM32H7 support
Replies: 173
Views: 27004

Re: Where to start STM32H7 support

Giovanni wrote:Good to know, I will resume work on this next. Is support for the old revision still required? probably there are lots of parts on the field.

We will certainly need to support both revY and revV for quite a few years in ArduPilot (usual lifetime would be 5 years or so). Luckily that won't be hard.
by tridge
Mon Nov 25, 2019 8:58 am
Forum: STM32 Support
Topic: Where to start STM32H7 support
Replies: 173
Views: 27004

Re: Where to start STM32H7 support

I received my first boards with the new RevisionV of the H743 chip today. It was a lot less hassle than I expected. It turns out our existing ArduPilot code runs on it fine with no changes. That is partly luck because of ADC clocking choices, but it certainly makes our life easy. I haven't yet tried...
by tridge
Sat Nov 23, 2019 1:12 pm
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

I still haven't worked out why the rcc reset method of avoiding interrupt storms wasn't completely effective, but I am planning to try to fix is using this: if (i2cp->isr_count++ > i2cp->isr_limit) { i2cp->errors |= I2C_ISR_LIMIT; i2cp->i2c->CR1 |= I2C_CR1_SWRST; // reset i2c i2cp->i2c->CR1 &= ~...
by tridge
Sat Nov 23, 2019 1:04 pm
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

It turns out that STM32F7xx has this issue too, see errata 2.11.2 in ES0334 Rev 5.
so we better apply this to all stm32 parts
by tridge
Sat Nov 23, 2019 9:14 am
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

another i2c interrupt storm bug [patch]

We've run across another I2C scenario which can generate an interrupt storm, and can (occasionally) defeat the i2c interrupt storm protection code we now have in ArduPilot (as discussed previously here: http://www.chibios.com/forum/viewtopic.php?f=16&t=5198) The bug happened in flight on a STM32...
by tridge
Mon Oct 07, 2019 9:53 am
Forum: Bug Reports
Topic: Preventing interrupt storms on STM32
Replies: 25
Views: 2274

Re: Preventing interrupt storms on STM32

Fixed the BTF clearing as bug #1045. thanks! I am still looking into implementing that "IRQ storm" handling concept. ok, thanks. If you need anything more from me on that then let me know. We've been running it for a while now and it is nice to know that if we do find another similar bug ...

Go to advanced search