Search found 130 matches

by tridge
Mon Dec 16, 2019 11:30 am
Forum: Development and Feedback
Topic: [RFC] Functional Safety in HAL
Replies: 11
Views: 1573

Re: [RFC] Functional Safety in HAL

Thanks for starting this discussion! A few random thoughts .... I'm not keen on setjmp/longjmp if it can be avoided. It can make debugging hard and also hard to reason about locking. There are places in things like interpreters where the flow of control needed means using jumps makes sense, but I'm ...
by tridge
Mon Dec 16, 2019 7:08 am
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

I applied the first two patches on trunk, I also added some extra DMA disable on another MSG_TIMEOUT exit path. In addition I made similar changes to I2Cv2 and I2Cv3, I think the DMA-disable-on-timeout problem existed there too. I've had a look at your changes. I am concerned that they limit the DM...
by tridge
Mon Dec 16, 2019 6:32 am
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

Thanks. I've now just found another I2Cv1 case of an unhandled interrupt. This one is SB set without BUSY set. I've got a reproducible test case where it can happen if I unplug an I2C compass while it is actively transmitting. In this case the storm doesn't seem to persist forever. Most I've seen is...
by tridge
Thu Nov 28, 2019 4:04 am
Forum: Bug Reports
Topic: audit of ISR/DMA issues
Replies: 4
Views: 450

audit of SPI

The SPI drivers are structured a bit differently, as the thread suspend happens not in the low level driver but up in the higher level hal code. It also is much less likely that SPI will suffer from the issues in this discussion as it doesn't have any handshaking, so the state of the peripheral (at ...
by tridge
Thu Nov 28, 2019 3:52 am
Forum: Bug Reports
Topic: audit of ISR/DMA issues
Replies: 4
Views: 450

audit of I2Cv2 and I2Cv3

I2Cv2 and v3 have similar structure to I2Cv1 so it isn't surprising that they have the same issues. Here are places where dma is enabled in interrupt context without checking to see if an I2C transaction is actually in progress: https://github.com/ChibiOS/ChibiOS/blob/master/os/hal/ports/STM32/LLD/I...
by tridge
Thu Nov 28, 2019 12:54 am
Forum: Bug Reports
Topic: audit of ISR/DMA issues
Replies: 4
Views: 450

audit of ISR/DMA issues

This is a follow-up of the discussions here: http://www.chibios.com/forum/viewtopic.php?f=35&t=5298&start=10 We need to audit the code for similar issues. The issues are: (1) DMA being enabled from within an interrupt handler for a peripheral due to spurious interrupts outside of the context...
by tridge
Tue Nov 26, 2019 8:00 pm
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

Those busy loops are there to wait the end of STOP from previous operation, there is no way to have an interrupt for that. ok, but could we make the timeout much shorter? It looks like the maximum would be Tbuf, which is max 4.7us. At the moment it uses the timeout provided for the next transaction...
by tridge
Tue Nov 26, 2019 9:46 am
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

one thing I didn't like the look of in I2Cv2 and I2Cv3 is the busy loop waiting for I2C_ISR_BUSY to be clear: https://github.com/ardupilot/ChibiOS/blob/master/os/hal/ports/STM32/LLD/I2Cv2/hal_i2c_lld.c#L1199 https://github.com/ardupilot/ChibiOS/blob/master/os/hal/ports/STM32/LLD/I2Cv3/hal_i2c_lld.c#...
by tridge
Tue Nov 26, 2019 9:30 am
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

About the audit, it would be a good idea. great. I'll start having a look at SPI next. I guess CAN would be the other one to look at. I'm not sure it applies to UARTs, or at least not in the same way. I think I2Cv1 is the worst offender definitely. I2Cv1 bugs have crashed a lot of aircraft over the...
by tridge
Tue Nov 26, 2019 9:24 am
Forum: Bug Reports
Topic: another i2c interrupt storm bug [patch]
Replies: 22
Views: 1572

Re: another i2c interrupt storm bug [patch]

Is this one the only patch? I think you forgot to attach the previous 3 ones. The earlier patches were attached to my earlier messages. I've now also done patches for I2Cv2 and I2Cv3. I didn't manage to produce the interrupt storm or DMA corruption on either STM32F765 or on STM32H743, but I still a...

Go to advanced search